-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dockerfile_base_amazonlinux #130
Conversation
This dockerfile will be used to create daemon image with the amazonlinux base image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the name less cumbersome? Like Dockerfile.amazonlinux
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to use an ARG and pass --build-arg
when building instead of duplicating the dockerfile.
Hi, can I have why the image is rollbacked? |
Hi @shogo82148 Currently, the Dockerhub image is based on |
@srprash Thank you for your reply. I understood. I'm migrating my service from EC2 to ECS, and looking for a pre-built image of X-Ray daemon. I'm going to use the ECR image, thanks again! |
This dockerfile will be used to create daemon image with the amazonlinux base image
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.