Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile_base_amazonlinux #130

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Create Dockerfile_base_amazonlinux #130

merged 3 commits into from
Apr 16, 2021

Conversation

srprash
Copy link
Collaborator

@srprash srprash commented Apr 16, 2021

This dockerfile will be used to create daemon image with the amazonlinux base image

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This dockerfile will be used to create daemon image with the amazonlinux base image
@wangzlei wangzlei self-requested a review April 16, 2021 18:54
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the name less cumbersome? Like Dockerfile.amazonlinux or something?

@srprash srprash merged commit e109554 into master Apr 16, 2021
@srprash srprash deleted the srprash-patch-4 branch April 16, 2021 19:15
Copy link

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to use an ARG and pass --build-arg when building instead of duplicating the dockerfile.

@shogo82148
Copy link

Rollback Dockerhub image base to AmazonLinux PR #130

Hi, can I have why the image is rollbacked?
Is there any problem on the scratch based image?

@srprash
Copy link
Collaborator Author

srprash commented Nov 29, 2021

Hi @shogo82148
The Dockerhub image was switched back to use the amazonlinux base image. When using the scratch base image, we unintentionally broke some customers who were relying on some bash tools which are shipped with amazonlinux but not with scratch. Please see these related issue for more details: #119, #128

Currently, the Dockerhub image is based on amazonlinux and the ECR image is based on scratch to maintain the existing customer experience. Are you facing any issue with these images?

@shogo82148
Copy link

@srprash Thank you for your reply. I understood.

I'm migrating my service from EC2 to ECS, and looking for a pre-built image of X-Ray daemon.
I have currently no problem, but I was just wondering.

I'm going to use the ECR image, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants