change server listen error log to info #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Jun 10, 2021
anuraaga
reviewed
Jun 10, 2021
pkg/proxy/server.go
Outdated
| @@ -133,7 +133,7 @@ func (s *Server) Serve() { | |||
| log.Infof("Starting proxy http server on %s", s.Addr) | |||
| err := s.ListenAndServe() | |||
| if err != nil { | |||
| log.Errorf("unable to start the server: %v", err) | |||
| log.Infof("proxy http server has stopped listening: %v", err) | |||
There was a problem hiding this comment.
Found we need to check against ServerClosed
https://stackoverflow.com/questions/39320025/how-to-stop-http-listenandserve
There was a problem hiding this comment.
Great catch, updated
anuraaga
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#144
Description of changes:
Changes the log-level and wording of the error message when the proxy server stops listening. I also audited other log messages added in #138 but the rest appear to be legitimate errors that should still be logged as such.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.