aws-xray-daemon:3.3.2 starts logging Error level message while stopping x-ray daemon container

[atakidev]

Issue Description:

public.ecr.aws/xray/aws-xray-daemon:3.3.2 starts logging the following "Error" ( [Error] unable to start the server: http: Server closed ) message while stopping the daemon container.

2021-06-09T12:25:40Z [Info] Starting proxy http server on 0.0.0.0:2000
2021-06-09T12:26:34Z [Info] Got shutdown signal: terminated
2021-06-09T12:26:34Z [Error] unable to start the server: http: Server closed

On the other hand, I couldn't see Error message when I tested with public.ecr.aws/xray/aws-xray-daemon:3.3.1 .
aws-xray-daemon:3.3.1 only show like the following message when I set log level to info .

2021-06-09T12:35:10Z [Info] Starting proxy http server on 127.0.0.1:2000
2021-06-09T12:36:37Z [Info] Got shutdown signal: terminated

How to reproduce this issue:

1. Start x-ray daemon container.

  $ docker pull public.ecr.aws/xray/aws-xray-daemon:3.3.2
  $ docker run -d public.ecr.aws/xray/aws-xray-daemon:3.3.2

2. Check container is started successfully.

  $ docker ps

3. Stop x-ray container after 20-30 seconds.

  $ docker stop <container-id>

4. Check log from the container.

  $ docker logs <container-id>

You will see "[Error] unable to start the server: http: Server closed" in the output of the container.

I tested the above step with public.ecr.aws/xray/aws-xray-daemon:3.3.1 . However, I couldn't reproduce this issue.
Note: When I start aws-xray-daemon:3.3.1, I used the following command to set log level.

  $ docker run -d public.ecr.aws/xray/aws-xray-daemon:3.3.1 -l info

Investigation:

From the error message, I guess this issue is the side effect of the following change because the following code added "log.Errorf("unable to start the server: %v", err)" in pkg/proxy/server.go to show err variable.

• Add logs for ignored errors Add logs for ignored errors #138

Based on the above change, I think we can ignore the message. However, the [Error] level message looks to mislead anybody who use the container. So, I think the message should not have Error level log.

Could you please consider to improve the log message?

Please let me know if you need additional information.

[willarmiros]

Hi @atakidev,

Thanks for raising this. I've opened #145 to address the log message. Please let me know if you think that is satisfactory.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in next 7 days. Thank you for your contributions.