Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amazonq): add missing metrics #622

Merged
merged 6 commits into from
Nov 17, 2023
Merged

feat(amazonq): add missing metrics #622

merged 6 commits into from
Nov 17, 2023

Conversation

dianaabv16
Copy link
Contributor

Problem

  • remove amazonq_approachIteration and amazonq_codeGenerationIteration.
  • moved its metrics to amazonq_approachInvoke and amazonq_codeGenerationInvoke accordingly
  • added amazonqEndOfTheConversationLatency and amazonqNumberOfReferences

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dianaabv16 dianaabv16 requested a review from a team as a code owner November 17, 2023 16:14
@dianaabv16 dianaabv16 changed the title Amazonq add missing metrics feat(amazonq): add missing metrics Nov 17, 2023
jpinkney-aws
jpinkney-aws reviewed Nov 17, 2023
View reviewed changes
telemetry/definitions/commonDefinitions.json Outdated Show resolved Hide resolved
telemetry/definitions/commonDefinitions.json Outdated Show resolved Hide resolved
telemetry/definitions/commonDefinitions.json Outdated Show resolved Hide resolved
@jpinkney-aws jpinkney-aws merged commit 84ae30e into aws:main Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkomonen-amazon nkomonen-amazon nkomonen-amazon approved these changes

@jpinkney-aws jpinkney-aws Awaiting requested review from jpinkney-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dianaabv16 @jpinkney-aws @nkomonen-amazon