-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(protocoltests): add S3 Client #6178
Draft
trivikr
wants to merge
6
commits into
aws:main
Choose a base branch
from
trivikr:aws-protocoltests-s3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
force-pushed
the
aws-protocoltests-s3
branch
2 times, most recently
from
July 9, 2024 14:16
ad85d41
to
335de89
Compare
trivikr
force-pushed
the
aws-protocoltests-s3
branch
from
July 9, 2024 15:17
335de89
to
b88ce57
Compare
CI failure in build src/S3Client.ts:311:58 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'S3ResolvedConfig'.
Type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & UserAgentResolvedConfig' is missing the following properties from type 'S3ResolvedConfig': followRegionRedirects, s3ExpressIdentityProvider
311 this.middlewareStack.use(getValidateBucketNamePlugin(this.config));
~~~~~~~~~~~
src/S3Client.ts:313:64 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'PreviouslyResolved'.
Property 'followRegionRedirects' is missing in type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & UserAgentResolvedConfig' but required in type 'PreviouslyResolved'.
313 this.middlewareStack.use(getRegionRedirectMiddlewarePlugin(this.config));
~~~~~~~~~~~
../../packages/middleware-sdk-s3/dist-types/region-redirect-middleware.d.ts:7:5
7 followRegionRedirects: boolean;
~~~~~~~~~~~~~~~~~~~~~
'followRegionRedirects' is declared here.
src/runtimeConfig.ts:48:15 - error TS2339: Property 'disableS3ExpressSessionAuth' does not exist on type 'S3ClientConfig'.
48 config?.disableS3ExpressSessionAuth ?? loadNodeConfig(NODE_DISABLE_S3_EXPRESS_SESSION_AUTH_OPTIONS),
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 3 errors in 2 files.
Errors Files
2 src/S3Client.ts:311
1 src/runtimeConfig.ts:48
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal JS-5057
Description
Adds S3 client in RestXml Protocol tests
Testing
CI
Additional context
Previous attempt in #5166
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.