don't overwrite defaulted config #6166
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
What does this implement/fix? Explain your changes.
The documentation for the credentials option would lead you to think an explicit undefined or omitting the option would use the default credential provider, the current implementation only works for the latter scenario. Explicitly passing undefined uses the default provider in v2.
In the scenario that a user provides
credentials: undefined
in the config object, because it is spread at the end of the object, the defaulted properties are overwrittenTesting
How was this change tested?
Additional context
Add any other context about the PR here.
Checklist
@public
tag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.