-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware-sdk-s3): add middleware for following region redirects #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
siddsriv
force-pushed
the
s3-global-client
branch
from
September 7, 2023 16:34
716ddc9
to
30b56e0
Compare
siddsriv
force-pushed
the
s3-global-client
branch
from
September 7, 2023 16:35
30b56e0
to
6f5c153
Compare
trivikr
reviewed
Sep 22, 2023
siddsriv
changed the title
feat(middleware-sdk-s3): add middleware for following region redirects
[DRAFT] feat(middleware-sdk-s3): add middleware for following region redirects
Sep 25, 2023
siddsriv
force-pushed
the
s3-global-client
branch
from
September 25, 2023 19:45
8ed442b
to
c66cd1f
Compare
siddsriv
changed the title
[DRAFT] feat(middleware-sdk-s3): add middleware for following region redirects
feat(middleware-sdk-s3): add middleware for following region redirects
Sep 27, 2023
kuhe
reviewed
Oct 3, 2023
kuhe
approved these changes
Oct 3, 2023
siddsriv
force-pushed
the
s3-global-client
branch
from
October 3, 2023 19:20
4222c52
to
a36ca30
Compare
trivikr
approved these changes
Oct 3, 2023
3 tasks
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1807
Description
Adds a middleware for following region redirects to support S3 global client.
Testing
Unit tests and E2E tests added and confirmed that they succeed.
E2E test:
Unit test:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.