-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump minimum go version to 1.19 #5047
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| [](https://docs.aws.amazon.com/sdk-for-go/api) [](https://gitter.im/aws/aws-sdk-go?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) [](https://github.com/aws/aws-sdk-go/actions/workflows/go.yml) [](https://github.com/aws/aws-sdk-go/blob/main/LICENSE.txt) | ||
|
|
||
| aws-sdk-go is the official AWS SDK for the Go programming language. | ||
| aws-sdk-go is the v1 AWS SDK for the Go programming language. | ||
|
|
||
| Checkout our [release notes](https://github.com/aws/aws-sdk-go/releases) for | ||
| information about the latest bug fixes, updates, and features added to the SDK. | ||
|
|
@@ -19,46 +19,14 @@ Jump To: | |
| ## Getting Started | ||
|
|
||
| ### Installing | ||
| Use `go get` to retrieve the SDK to add it to your `GOPATH` workspace, or | ||
| project's Go module dependencies. | ||
| Use `go get` to retrieve the SDK to add it to your project's Go module dependencies. | ||
|
|
||
| go get github.com/aws/aws-sdk-go | ||
|
|
||
| To update the SDK use `go get -u` to retrieve the latest version of the SDK. | ||
|
|
||
| go get -u github.com/aws/aws-sdk-go | ||
|
|
||
| ### Dependencies | ||
|
|
||
| The SDK includes a `vendor` folder containing the runtime dependencies of the | ||
| SDK. The metadata of the SDK's dependencies can be found in the Go module file | ||
| `go.mod` or Dep file `Gopkg.toml`. | ||
|
|
||
| ### Go Modules | ||
|
|
||
| If you are using Go modules, your `go get` will default to the latest tagged | ||
| release version of the SDK. To get a specific release version of the SDK use | ||
| `@<tag>` in your `go get` command. | ||
|
|
||
| go get github.com/aws/[email protected] | ||
|
|
||
| To get the latest SDK repository change use `@latest`. | ||
|
|
||
| go get github.com/aws/aws-sdk-go@latest | ||
|
|
||
| ### Go 1.5 | ||
|
|
||
| If you are using Go 1.5 without vendoring enabled, (`GO15VENDOREXPERIMENT=1`), | ||
| you will need to use `...` when retrieving the SDK to get its dependencies. | ||
|
|
||
| go get github.com/aws/aws-sdk-go/... | ||
|
|
||
| This will still include the `vendor` folder. The `vendor` folder can be deleted | ||
| if not used by your environment. | ||
|
|
||
| rm -rf $GOPATH/src/github.com/aws/aws-sdk-go/vendor | ||
|
|
||
|
|
||
| ## Quick Examples | ||
|
|
||
| ### Complete SDK Example | ||
|
|
@@ -490,6 +458,15 @@ For information about maintenance and support for SDK major versions and our und | |
| * [AWS SDKs and Tools Maintenance Policy](https://docs.aws.amazon.com/credref/latest/refdocs/maint-policy.html) | ||
| * [AWS SDKs and Tools Version Support Matrix](https://docs.aws.amazon.com/credref/latest/refdocs/version-support-matrix.html) | ||
|
|
||
| ### Go version support policy | ||
|
|
||
| The v2 SDK follows the upstream [release policy](https://go.dev/doc/devel/release#policy) | ||
| with an additional six months of support for the most recently deprecated | ||
| language version. | ||
|
|
||
| **AWS reserves the right to drop support for unsupported Go versions earlier to | ||
| address critical security issues.** | ||
|
|
||
| ## Resources | ||
|
|
||
| [Developer guide](https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/welcome.html) - This document | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| module github.com/aws/aws-sdk-go | ||
|
|
||
| go 1.19 | ||
|
|
||
| require ( | ||
| github.com/jmespath/go-jmespath v0.4.0 | ||
| github.com/pkg/errors v0.9.1 | ||
| golang.org/x/net v0.1.0 | ||
| ) | ||
|
|
||
| go 1.11 | ||
| require golang.org/x/text v0.4.0 // indirect |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small question: will that deletion affect PR CI of branches with prefix "feat-"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we did this in v2, it was duplicating checks.