Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export s3shared ResponseError and GetHostIDMetadata in S3 and S3 Control client packages. #983

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Export s3shared ResponseError and GetHostIDMetadata in S3 and S3 Control client packages. #983

merged 2 commits into from
Dec 17, 2020

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Dec 16, 2020 •
edited by jasdel
Loading

Exports an interface definition in the S3 and S3 Control client packages for the s3shared.ResponseError type. Exports a wrapper around the s3shared.GetHostIDMetadata.

Fixes #919
Fixes #918

@skmcgrail skmcgrail requested a review from jasdel December 16, 2020 03:09
skotambkar
skotambkar reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@skotambkar skotambkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few thoughts/questions

service/s3/api_client.go Show resolved Hide resolved
service/s3control/api_client.go Show resolved Hide resolved
@skotambkar skotambkar mentioned this pull request Dec 16, 2020
Open
@skmcgrail skmcgrail merged commit fa8f74a into aws:master Dec 17, 2020
@skmcgrail skmcgrail deleted the s3HostId branch December 17, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotambkar skotambkar skotambkar left review comments

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@skmcgrail @jasdel @skotambkar