Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user agent to add business metrics at the end instead of prepend them #2916

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Madrigal
Copy link
Contributor

User Agent looked like this

m/E aws-sdk-go-v2/1.32.5 os/macos lang/go#1.22.0 md/GOOS#darwin md/GOARCH#arm64 api/s3#1.69.0

Having business metrics at the beginning was not compliant. We also didn't add the user agent metadata version.

Now it looks like

aws-sdk-go-v2/1.32.5 ua/2.1 os/macos lang/go#1.22.0 md/GOOS#darwin md/GOARCH#arm64 api/s3#1.69.0 m/E

@Madrigal Madrigal requested a review from a team as a code owner November 29, 2024 21:08
@Madrigal Madrigal merged commit 2835f7b into main Nov 29, 2024
13 checks passed
@Madrigal Madrigal deleted the fix-user-agent-21 branch November 29, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants