Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make endpoint url integration test env-resilient #2840

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Oct 15, 2024

Our internal build process sets AWS_PROFILE before running integration tests, so the endpoint URL tests I added today were failing.

Double-checked that setting a value for AWS_PROFILE and running this test still passes.

@lucix-aws lucix-aws requested a review from a team as a code owner October 15, 2024 23:23
@lucix-aws lucix-aws merged commit 04e7aca into main Oct 16, 2024
13 checks passed
@lucix-aws lucix-aws deleted the fix-integtest branch October 16, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant