extend metrics with retry-related instruments #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
force-pushed
the
feat-observability
branch
from
4c720d0 to
dd65e18
Compare
lucix-aws
force-pushed
the
feat-observability-metrics
branch
from
8f37381 to
0850f37
Compare
Madrigal
approved these changes
Sep 18, 2024
| end := time.Now() | ||
|
|
||
| elapsed := end.Sub(start) | ||
| instr.Record(ctx, float64(elapsed)/1e9, opts...) |
There was a problem hiding this comment.
not a blocker, but I still dislike this. Are we instructing customers when using their own metrics to conform to this format as well when recording duration? If so, what happens if they don't?
wty-Bryant
approved these changes
Sep 18, 2024
lucix-aws
added a commit
that referenced
this pull request
Sep 18, 2024
* extend metrics with retry-related instruments * fix sdk.NowTime test shenanigans * regen s3
lucix-aws
added a commit
that referenced
this pull request
Sep 19, 2024
* extend metrics with retry-related instruments * fix sdk.NowTime test shenanigans * regen s3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics component of #1744.
Extends upstream metrics additions from aws/smithy-go#536 with the following instruments (and their dimensions):
client.call.errors- number of errors encountered (service, operation, error type)client.call.attempts- number of attempts made (service, operation)client.call.attempt_duration- time span for an entire attempt (service, operation)This is not the final merge before release, as some minor tweaks need to be made to some of the component names to align with our internal guidelines.