add blurb on disabling endpoint prefix #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madrigal
approved these changes
Sep 11, 2024
| @@ -23,7 +23,7 @@ | |||
| <meta property="og:title" content="404 Page not found" /> | |||
| <meta property="og:description" content="The AWS SDK for Go V2 provides APIs and utilities that developers can use to build Go applications that use AWS services." /> | |||
| <meta property="og:type" content="website" /> | |||
| <meta property="og:url" content="http://localhost:1313/aws-sdk-go-v2/404.html" /> | |||
| @@ -99,7 +99,7 @@ | |||
| aria-label="Search this site…" | |||
| autocomplete="off" | |||
|
|
|||
| data-offline-search-index-json-src="/aws-sdk-go-v2/offline-search-index.30b245754e63db1f94dcbaa3ba0f9915.json" | |||
| data-offline-search-index-json-src="/aws-sdk-go-v2/offline-search-index.1ed5201c9429d6d49ab1e6d6c5e5409e.json" | |||
There was a problem hiding this comment.
Were you able to confirm if this offline search works?
There was a problem hiding this comment.
I did actually check this and it worked for me both in the preview and on the current render of the public site. We'll see what happens when this merges and gets propagated. The search index appears to get a new filename every time, it's possible that it just went out of sync in a previous pass on re-generating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instructions on how to disable endpoint prefixes being applied, inspired by an internal conversation on the topic.