validate put object content length #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Jun 19, 2024
Madrigal
approved these changes
Jun 19, 2024
| }) | ||
|
|
||
| _, err := svc.PutObject(context.Background(), cs.Input) | ||
| if cs.ExpectErr && !strings.Contains(err.Error(), errNoContentLength.Error()) { |
There was a problem hiding this comment.
[nit] can this be compared with errors.Is or errors.As instead of doing string comparisons?
There was a problem hiding this comment.
Yeah not sure what I was doing here. This is errors.Is with extra steps
| "github.com/aws/smithy-go/middleware" | ||
| ) | ||
|
|
||
| var errNoContentLength = errors.New( |
wty-Bryant
pushed a commit
that referenced
this pull request
Jun 19, 2024
This reverts commit 2f18ba5. revert
wty-Bryant
pushed a commit
that referenced
this pull request
Jun 19, 2024
This reverts commit 2f18ba5. revert
wty-Bryant
added a commit
that referenced
this pull request
Jun 19, 2024
* Revert "validate put object content length (#2690)" This reverts commit 2f18ba5. revert * add changelog --------- Co-authored-by: Tianyi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specific validation for content-length presence in PutObject, see middleware docs
Closes #2683 or at least mitigates it somewhat