add s3 protocol tests #2667
Merged
add s3 protocol tests #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
force-pushed
the
feat-s3protocoltests
branch
from
8811a3e to
3b98cdf
Compare
Madrigal
reviewed
Jun 4, 2024
service/s3/manual_protocol_test.go
Outdated
| t.Fatal("captured request is nil") | ||
| } | ||
|
|
||
| if tt.ExpectMethod != r.r.Method { |
There was a problem hiding this comment.
[nit] can we assign a variable to r.r like req so we don't have to r.r our way on all tests?
There was a problem hiding this comment.
Do test GetBucketLocationUnwrappedOutput and S3OperationNoErrorWrappingResponse on the protocol test make sense for us?
yes, added them
can we assign a variable to r.r like req
done
Madrigal
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add smithy-borne s3-specific protocol tests. We have to do this manually for now because of our customization structure, see the comment.