feat: rpc2cbor: sdk protocol generator extension #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
force-pushed
the
feat-rpc2-protogen
branch
from
f388e71 to
f0f1574
Compare
wty-Bryant
approved these changes
Mar 13, 2024
lucix-aws
force-pushed
the
feat-rpc2-protogen
branch
2 times, most recently
from
388d7ab to
9a02554
Compare
lucix-aws
force-pushed
the
feat-rpc2-protogen
branch
from
9a02554 to
7e54b97
Compare
lucix-aws
added a commit
that referenced
this pull request
Mar 29, 2024
lucix-aws
added a commit
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends upstream changes in aws/smithy-go#507 to generate event streams and protocol tests for rpcv2-cbor.
This patch mutates the kinesis model to demonstrate event stream codegen. That will be removed once it hits the integration branch. Middleware snapshot tests will fail because of this.
Protocol tests are passing as of 3/12 (CI will reflect this) and are generated from their state in adwsingh/smithy#1.