Allow unknown traits when generating SDK #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Smithy Gradle Plugin config to allow unkown traits, stopping builds from failing if there are traits in models which haven't been added as a dependency in the code generator. Usually new traits are added to existing packages, but if/when a trait is added in a new package, we will have to update the dependencies of the code generator, even if the code generator isn't actually using the trait yet.
|
Closing in favor of #2447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Smithy Gradle Plugin config to allow unkown traits, stopping builds from failing if there are traits in models which haven't been added as a dependency in the code generator. Usually new traits are added to existing packages, but if/when a trait is added in a new package, we will have to update the dependencies of the code generator, even if the code generator isn't actually using the trait yet.