Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regen select services for upstream auth resolver addition #2299

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Oct 2, 2023

S3 and EventBridge are shown as examples of the output but will ultimately be replaced by custom rules-based implementations.

@lucix-aws lucix-aws requested a review from a team as a code owner October 2, 2023 21:39
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looking at the auth.go files, the PR LGTM.

smithyhttp.NewAnonymousOption(),
}
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra new lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants