Skip to content

Commit

Permalink
update integ test dependency version
Browse files Browse the repository at this point in the history
  • Loading branch information
Tianyi Wang committed Nov 5, 2024
1 parent 87da110 commit 99ef473
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions feature/s3/transfermanager/pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func newDefaultSlicePool(sliceSize int64, capacity int) *defaultSlicePool {
return p
}

var errZeroCapacity = fmt.Errorf("get called on zero capacity pool")
var zeroCapacityErr = fmt.Errorf("get called on zero capacity pool")

Check failure on line 30 in feature/s3/transfermanager/pool.go

View workflow job for this annotation

GitHub Actions / Unix SDK tests (ubuntu-latest, 1.21)

error var zeroCapacityErr should have name of the form errFoo

Check failure on line 30 in feature/s3/transfermanager/pool.go

View workflow job for this annotation

GitHub Actions / Unix SDK tests (ubuntu-latest, 1.22)

error var zeroCapacityErr should have name of the form errFoo

Check failure on line 30 in feature/s3/transfermanager/pool.go

View workflow job for this annotation

GitHub Actions / Unix SDK tests (ubuntu-latest, 1.23)

error var zeroCapacityErr should have name of the form errFoo

Check failure on line 30 in feature/s3/transfermanager/pool.go

View workflow job for this annotation

GitHub Actions / Unix SDK tests (macos-latest, 1.23)

error var zeroCapacityErr should have name of the form errFoo

func (p *defaultSlicePool) Get(ctx context.Context) ([]byte, error) {
select {
Expand All @@ -40,7 +40,7 @@ func (p *defaultSlicePool) Get(ctx context.Context) ([]byte, error) {
select {
case bs, ok := <-p.slices:
if !ok {
return nil, errZeroCapacity
return nil, zeroCapacityErr
}
return bs, nil
case <-ctx.Done():
Expand Down
2 changes: 1 addition & 1 deletion service/internal/integrationtest/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ require (
github.com/aws/aws-sdk-go-v2 v1.32.3
github.com/aws/aws-sdk-go-v2/config v1.28.1
github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.35
github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager v1.0.0
github.com/aws/aws-sdk-go-v2/feature/s3/transfermanager v0.1.0
github.com/aws/aws-sdk-go-v2/service/acm v1.30.3
github.com/aws/aws-sdk-go-v2/service/apigateway v1.27.3
github.com/aws/aws-sdk-go-v2/service/applicationautoscaling v1.33.3
Expand Down
6 changes: 4 additions & 2 deletions service/internal/integrationtest/go.sum
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
github.com/aws/smithy-go v1.22.0 h1:uunKnWlcoL3zO7q+gG2Pk53joueEOsnNB28QdMsmiMM=
github.com/aws/smithy-go v1.22.0/go.mod h1:irrKGvNn1InZwb2d7fkIRNucdfwR8R+Ts3wxYa/cJHg=
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/jmespath/go-jmespath v0.4.0 h1:BEgLn5cpjn8UN1mAw4NjwDrS35OdebyEtFe+9YPoQUg=
github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo=
github.com/jmespath/go-jmespath/internal/testify v1.5.1 h1:shLQSRRSCCPj3f2gpwzGwWFoC7ycTf1rcQZHOlsJ6N8=
Expand All @@ -10,5 +11,6 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v2 v2.2.8 h1:obN1ZagJSUGI0Ek/LBmuj4SNLPfIny3KsKFopxRdj10=
gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=
gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=

0 comments on commit 99ef473

Please sign in to comment.