backfill @required on imagebuilder#LaunchTemplateConfiguration.SetDef…

…aultVersion (#2838)
aws · Oct 16, 2024 · 09f35b4 · 09f35b4
1 parent 04e7aca
commit 09f35b4
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 7 deletions.
diff --git a/.changelog/139b04a8d6124cb29dfb9e66f9f70386.json b/.changelog/139b04a8d6124cb29dfb9e66f9f70386.json
@@ -0,0 +1,8 @@
+{
+    "id": "139b04a8-d612-4cb2-9dfb-9e66f9f70386",
+    "type": "bugfix",
+    "description": "**BREAKING CHANGE**: The type of LaunchTemplateConfiguration.SetDefaultVersion has been changed from `bool` to `*bool`. Before this change, the field was incorrectly marked as having a default value of false by the service, which made it functionally impossible for users to express the full range of values for the field (true, false, and unset/nil), each of which have distinctly different behaviors.",
+    "modules": [
+        "service/imagebuilder"
+    ]
+}
diff --git a/.../main/java/software/amazon/smithy/aws/go/codegen/customization/BackfillRequiredTrait.java b/.../main/java/software/amazon/smithy/aws/go/codegen/customization/BackfillRequiredTrait.java
@@ -54,4 +54,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
                 ShapeId.from(serviceId),
                 Arrays.stream(shapeIds).map(ShapeId::from).collect(toSet()));
     }
-}
+}
diff --git a/...gen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/RemoveDefaults.java b/...gen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/RemoveDefaults.java
@@ -32,7 +32,11 @@ public class RemoveDefaults implements GoIntegration {
         serviceToShapeIds("com.amazonaws.paymentcryptographydata#PaymentCryptographyDataPlane",
                 "com.amazonaws.paymentcryptographydata#IntegerRangeBetween4And12"),
         serviceToShapeIds("com.amazonaws.emrserverless#AwsToledoWebService",
-                "com.amazonaws.emrserverless#WorkerCounts"));
+                "com.amazonaws.emrserverless#WorkerCounts"),
+        serviceToShapeIds("com.amazonaws.imagebuilder#imagebuilder",
+                    // https://github.com/aws/aws-sdk-go-v2/issues/2734
+                    // V1479153907
+                    "com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion"));
 
     private boolean mustPreprocess(ShapeId service) {
         return toRemove.containsKey(service);
@@ -95,4 +99,4 @@ private static Map.Entry<ShapeId, Set<ShapeId>> serviceToShapeIds(String service
                 ShapeId.from(serviceId),
                 Arrays.stream(shapeIds).map(ShapeId::from).collect(Collectors.toSet()));
     }
-}
+}
diff --git a/service/imagebuilder/deserializers.go b/service/imagebuilder/deserializers.go
diff --git a/service/imagebuilder/serializers.go b/service/imagebuilder/serializers.go
diff --git a/service/imagebuilder/types/types.go b/service/imagebuilder/types/types.go
-Original file line number
+Diff line change
@@ Expand Up @@
                     ShapeId.from(serviceId),
                     Arrays.stream(shapeIds).map(ShapeId::from).collect(toSet()));
         }
-    }
+    }