Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Fix Slurm reservation deletion command #600

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

enrico-usai
Copy link
Contributor

The right command is scontrol delete ReservationName=xxx and not scontrol delete reservation ReservationName=xxx.

Tests

  • Manually tested in a running cluster.
  • I found this issue by simulating a transition from scheduled to active Capacity Block

References

The right command is `scontrol delete ReservationName=xxx`
and not `scontrol delete reservation ReservationName=xxx`.

Signed-off-by: Enrico Usai <[email protected]>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88b61da) 90.90% compared to head (684cb29) 90.90%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #600   +/-   ##
========================================
  Coverage    90.90%   90.90%           
========================================
  Files           20       20           
  Lines         3134     3134           
========================================
  Hits          2849     2849           
  Misses         285      285           
Flag Coverage Δ
unittests 90.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/common/schedulers/slurm_reservation_commands.py 98.85% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai merged commit 3533697 into aws:develop Nov 10, 2023
14 checks passed
@enrico-usai enrico-usai deleted the wip/cbr branch November 10, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants