Permit test_slurm_commands to pass on MacOS #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was failing on MacOS because by default it uses BSD grep, that does not accept `-P` option. With this change, after installing GNU grep the test will pass. GNU grep can be easily installed from Homebrew: `brew install grep`. ``` $ grep --version grep (BSD grep, GNU compatible) 2.6.0-FreeBSD $ brew install grep $ ggrep --version ggrep (GNU grep) 3.11 ... ``` Signed-off-by: Enrico Usai <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #576 +/- ##
========================================
Coverage 89.93% 89.93%
========================================
Files 16 16
Lines 2692 2692
========================================
Hits 2421 2421
Misses 271 271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmarciani
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Test was failing on MacOS because by default it uses BSD grep, that does not accept
-Poption.With this change, after installing GNU grep the test will pass. GNU grep can be easily installed from Homebrew:
brew install grep.Tests
test_slurm_commandson MacOS