Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Remove separation between oversubscribe and no-oversubscribe jobs #574

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

lukeseawalker
Copy link
Contributor

Description of changes

  • Remove separation between oversubscribe and no-oversubscribe jobs

Tests

  • unit tested

References

n/a

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d70da33) 89.98% compared to head (03f880a) 89.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #574      +/-   ##
===========================================
- Coverage    89.98%   89.93%   -0.06%     
===========================================
  Files           16       16              
  Lines         2706     2692      -14     
===========================================
- Hits          2435     2421      -14     
  Misses         271      271              
Flag Coverage Δ
unittests 89.93% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/slurm_plugin/instance_manager.py 100.00% <100.00%> (ø)
src/slurm_plugin/slurm_resources.py 95.42% <100.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeseawalker lukeseawalker enabled auto-merge (rebase) October 13, 2023 09:24
Copy link
Contributor

@NSsirena NSsirena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification step.

@lukeseawalker lukeseawalker merged commit d106ccc into aws:develop Oct 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants