Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deprecated flake8-mypy Python tox check #572

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jdeamicis
Copy link
Contributor

@jdeamicis jdeamicis commented Oct 11, 2023

Description of changes

  • Disable deprecated flake8-mypy Python tox check, which caused problems in the GitHub actions on the repository.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3ecda34) 89.44% compared to head (7fa28f7) 89.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.7     #572   +/-   ##
============================================
  Coverage        89.44%   89.44%           
============================================
  Files               16       16           
  Lines             2633     2633           
============================================
  Hits              2355     2355           
  Misses             278      278           
Flag Coverage Δ
unittests 89.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai merged commit 5349643 into aws:release-3.7 Oct 11, 2023
16 checks passed
@jdeamicis jdeamicis deleted the wip/3.7/disable_flake8_mypy branch October 11, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants