Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for greedy-all-or-nothing #569

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

EddyMM
Copy link
Contributor

@EddyMM EddyMM commented Oct 6, 2023

Description of changes

  • Add support for greedy-all-or-nothing

Tests

  • unit tests added
  • manual tests on running cluster

References

n/a

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (67d32db) 89.98% compared to head (c226cad) 89.98%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    89.98%   89.98%           
========================================
  Files           16       16           
  Lines         2706     2707    +1     
========================================
+ Hits          2435     2436    +1     
  Misses         271      271           
Flag Coverage Δ
unittests 89.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/slurm_plugin/common.py 82.35% <100.00%> (+0.26%) ⬆️
src/slurm_plugin/instance_manager.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeseawalker lukeseawalker marked this pull request as ready for review October 10, 2023 15:22
@lukeseawalker lukeseawalker requested review from a team as code owners October 10, 2023 15:22
@lukeseawalker lukeseawalker merged commit 1ec2a36 into aws:develop Oct 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants