Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.8] Add kitchen tests for internal shared efs #2506

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

dreambeyondorange
Copy link
Contributor

Adds the shared_internal_storage_* test suites for enviornment-config
Updates the matching mount_internal_use_efs_spec controls
Adds the mount_internal_use_ebs_spec controls for the case of ebs

Tests

  • Ran kitchen tests locally using an existing EFS file system for mounting the internal shared data
  • shared_internal_storage_headnode
  • shared_internal_storage_compute
  • shared_internal_storage_login

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds the shared_internal_storage_* test suites for enviornment-config
Updates the matching mount_internal_use_efs_spec controls
Adds the mount_internal_use_ebs_spec controls for the case of ebs
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57360b0) 76.06% compared to head (575b20a) 76.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.8    #2506   +/-   ##
============================================
  Coverage        76.06%   76.06%           
============================================
  Files               13       13           
  Lines             1876     1876           
============================================
  Hits              1427     1427           
  Misses             449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange merged commit 6046632 into aws:release-3.8 Oct 20, 2023
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants