Use custom_node_package and custom_awsbatchcli_package only when running system tests #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2504 +/- ##
========================================
Coverage 76.06% 76.06%
========================================
Files 13 13
Lines 1876 1876
========================================
Hits 1427 1427
Misses 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ing system tests These packages are not required in CI/CD because only config recipes are executed there, then they are not required by local ec2 or docker tests, because locally we execute specific tests/controls that should have all the required parameters. With this change we're also avoiding to install always version 3.4.1 of the node and use instead a package from develop. ### Tests * Created new test for custom awsbatch cli package installation * Improved existing test for custom node package installation to check if the package is available on pypi Executed: * `bash kitchen.ec2.sh computefleet-install test custom-parallelcluster-node-rocky8` * `bash kitchen.ec2.sh awsbatch-install test custom-awsbatchcli-package-rocky8` Signed-off-by: Enrico Usai <[email protected]>
enrico-usai
force-pushed
the
wip/develop
branch
from
d0247a1 to
f51e33e
Compare
lukeseawalker
approved these changes
Oct 19, 2023
jdeamicis
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages are not required in CI/CD because only config recipes are executed there, then they are not required by local ec2 or docker tests, because locally we execute specific tests/controls that should have all the required parameters.
With this change we're also avoiding to install always version 3.4.1 of the node and use instead a package from develop.
Tests
Executed:
bash kitchen.ec2.sh computefleet-install test custom-parallelcluster-node-rocky8bash kitchen.ec2.sh awsbatch-install test custom-awsbatchcli-package-rocky8