Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spack] Changing the default Spack Root directory from /home to /opt #2494

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented Oct 11, 2023

Description of changes

  • Changing the default location of Spack root folder from /home to /opt/parallelcluster/shared

Tests

  • Locally Creating an AMI and testing to install SW using Spack

release-3.8 #2519

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners October 11, 2023 17:57
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c8fe24) 76.06% compared to head (b658596) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2494   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 force-pushed the wip/spack-ad-tests branch 4 times, most recently from 90874c7 to 839bb8b Compare October 13, 2023 14:10
@himani2411 himani2411 marked this pull request as draft October 13, 2023 18:55
@dreambeyondorange dreambeyondorange changed the title [Spack]Changing the default Spack Root directory from /home to /opt [Spack] Changing the default Spack Root directory from /home to /opt Oct 16, 2023
@himani2411 himani2411 force-pushed the wip/spack-ad-tests branch 5 times, most recently from ac2e78a to d5ece2d Compare October 17, 2023 19:13
@himani2411 himani2411 marked this pull request as ready for review October 18, 2023 01:43
@himani2411 himani2411 force-pushed the wip/spack-ad-tests branch 9 times, most recently from a94e3d7 to da3f6f8 Compare October 20, 2023 20:37
@himani2411 himani2411 marked this pull request as draft October 20, 2023 21:35
@himani2411 himani2411 marked this pull request as ready for review October 20, 2023 23:21
@himani2411 himani2411 enabled auto-merge (squash) October 24, 2023 15:03
@himani2411 himani2411 merged commit e21f7d3 into aws:develop Oct 25, 2023
28 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Nov 13, 2023
himani2411 added a commit to himani2411/aws-parallelcluster-cookbook that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants