Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Move MungeKeySecretArn to Scheduling SlurmSettings #2491

Merged
merged 20 commits into from
Oct 12, 2023

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Oct 11, 2023

Description of changes

  • Move MungeKeySecretArn to Scheduling SlurmSettings instead of DevSettings MungeKeySettings to adopt changes in CLI PR

Tests

  • Manually tests done. Config, update and scripts work as expected.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

@hehe7318 hehe7318 requested review from a team as code owners October 11, 2023 00:04
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f6c7e6) 76.06% compared to head (8da265c) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2491   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hehe7318 hehe7318 marked this pull request as ready for review October 12, 2023 13:28
Copy link
Contributor

@jdeamicis jdeamicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all the commits with a nice commit message. GREAT JOB!

@hehe7318 hehe7318 merged commit 8bf4e46 into aws:develop Oct 12, 2023
28 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster-cookbook that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants