Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Move slurm_resume configuration in a sub-recipe #2483

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

NSsirena
Copy link
Contributor

@NSsirena NSsirena commented Oct 5, 2023

Description of changes

  • Move slurm_resume configuration in a sub-recipe
  • Creation of some directories required by the head node is moved into a dedicated subrecipe
  • Add ScalingStrategy parameter to slurm_resume config
  • Add a test to verify that slurm_resume related file and folders are properly created and configured

Tests

  • Unit test passed on all OS (validated on EC2 instances)

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cf39542) 76.06% compared to head (4a7977d) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2483   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NSsirena NSsirena force-pushed the jls/scaling-strategy branch from fe3c0a0 to 10c8bec Compare October 5, 2023 13:08
Also factor out the creation of some directory and add
ScalingStrategy parameter to slurm_resume config

Signed-off-by: Nicola Sirena <[email protected]>
@NSsirena NSsirena force-pushed the jls/scaling-strategy branch from 10c8bec to 1c645e7 Compare October 5, 2023 13:12
@NSsirena NSsirena force-pushed the jls/scaling-strategy branch from 9f9aaf0 to 3f5ae2e Compare October 5, 2023 16:33
@NSsirena NSsirena marked this pull request as ready for review October 5, 2023 17:13
@NSsirena NSsirena requested review from a team as code owners October 5, 2023 17:13
@NSsirena NSsirena enabled auto-merge (rebase) October 6, 2023 10:13
@NSsirena NSsirena merged commit d754cf9 into aws:develop Oct 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants