Fix strongSwan CI #2028
Merged
Fix strongSwan CI #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongSwan-6 released today and AWS-LC's job [started failing](https://github.com/aws/aws-lc/actions/runs/12141153061/job/33852603406?pr=2027). This is due to the new dependency on strongSwan's DRBG plugin to make their test vector plugin (i.e. KATs) run during a unit test run. A similar change to support this was added to the upstream CI job [here](strongswan/strongswan@ec98217#diff-52afcc694c0ff8ff253441f42ff44d6b4734fe30ae9070f2ba07a668a10e7baaL220)
justsmth
approved these changes
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
- Coverage 78.68% 78.67% -0.01%
==========================================
Files 598 598
Lines 103321 103321
Branches 14687 14686 -1
==========================================
- Hits 81296 81286 -10
- Misses 21375 21384 +9
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. |
nebeid
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #V1600301204
Description of changes:
strongSwan-6 released today and AWS-LC's job started failing. This is due to the new dependency on strongSwan's DRBG plugin to make their test vector plugin (i.e. KATs) run during a unit test run. A similar change to support this was added to the upstream CI job here
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Assert that the strongSwan CI passes now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.