-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix perl handling of paths w/ spaces #2005
Open
justsmth
wants to merge
7
commits into
aws:main
Choose a base branch
from
justsmth:perl-path-spaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
perl-path-spaces
branch
7 times, most recently
from
November 20, 2024 17:27
020a90d
to
fbc7115
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 78.90% 78.90% -0.01%
==========================================
Files 594 594
Lines 102415 102414 -1
Branches 14517 14516 -1
==========================================
- Hits 80812 80811 -1
Misses 20953 20953
Partials 650 650 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrewhop
reviewed
Nov 21, 2024
justsmth
force-pushed
the
perl-path-spaces
branch
5 times, most recently
from
November 21, 2024 19:16
63872b1
to
b26b40a
Compare
skmcgrail
previously approved these changes
Nov 22, 2024
justsmth
force-pushed
the
perl-path-spaces
branch
from
November 25, 2024 14:37
b26b40a
to
087f0aa
Compare
justsmth
force-pushed
the
perl-path-spaces
branch
4 times, most recently
from
November 25, 2024 18:29
3ad067c
to
417ef0d
Compare
justsmth
force-pushed
the
perl-path-spaces
branch
from
November 25, 2024 18:30
417ef0d
to
e6b710c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Build was failing when the source path contained spaces. This is due to there not being quotes around the
$xlate
and$output
at the start of the script.Call-outs:
Testing:
Added a test that sets up the paths for both the source and build directories to contain spaces.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.