Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perl handling of paths w/ spaces #2005

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Nov 20, 2024

Description of changes:

Build was failing when the source path contained spaces. This is due to there not being quotes around the $xlate and $output at the start of the script.

Call-outs:

  • Although this change alters a few Perl scripts, no changes are made to the assembly files they produce.

Testing:

Added a test that sets up the paths for both the source and build directories to contain spaces.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the perl-path-spaces branch 7 times, most recently from 020a90d to fbc7115 Compare November 20, 2024 17:27
@justsmth justsmth marked this pull request as ready for review November 20, 2024 17:28
@justsmth justsmth requested a review from a team as a code owner November 20, 2024 17:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (80f984e) to head (46b8da9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   78.90%   78.90%   -0.01%     
==========================================
  Files         594      594              
  Lines      102415   102414       -1     
  Branches    14517    14516       -1     
==========================================
- Hits        80812    80811       -1     
  Misses      20953    20953              
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@justsmth justsmth force-pushed the perl-path-spaces branch 5 times, most recently from 63872b1 to b26b40a Compare November 21, 2024 19:16
skmcgrail
skmcgrail previously approved these changes Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants