Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate 16k scratch on heap #1991

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Allocate 16k scratch on heap #1991

merged 2 commits into from
Nov 13, 2024

Conversation

justsmth
Copy link
Contributor

Issues:

Addresses: P169365635

Description of changes:

  • Allocate large value on the heap instead of stack.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.87%. Comparing base (096f73a) to head (25b951e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
+ Coverage   78.86%   78.87%   +0.01%     
==========================================
  Files         593      593              
  Lines      101934   101933       -1     
  Branches    14450    14451       +1     
==========================================
+ Hits        80386    80403      +17     
+ Misses      20904    20885      -19     
- Partials      644      645       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review November 13, 2024 18:12
@justsmth justsmth requested a review from a team as a code owner November 13, 2024 18:12
torben-hansen
torben-hansen previously approved these changes Nov 13, 2024
@justsmth justsmth merged commit f9757c4 into aws:main Nov 13, 2024
112 of 116 checks passed
@justsmth justsmth deleted the speed-heap branch November 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants