Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses aws/aws-lc-rs#574
Context
The compiler cannot always confirm that the array indices used are within the required bounds. On certain platform, specifically powerpc64le in this case, the compiler may generate a warning about it. For our build, warnings are treated as errors thus causing compilation to fail.
Description of changes:
Adds sanity checks to several locations in
gcm.c
that abort if the logic would reference an out-of-bounds index of an array.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.