-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine-Linux-x86 to GitHub Actions CI #1753
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 78.49% 78.48% -0.01%
==========================================
Files 585 585
Lines 99630 99630
Branches 14253 14254 +1
==========================================
- Hits 78201 78199 -2
- Misses 20794 20796 +2
Partials 635 635 ☔ View full report in Codecov by Sentry. |
skmcgrail
previously approved these changes
Aug 9, 2024
andrewhop
reviewed
Aug 9, 2024
I'd suggest to use more native way like this one https://github.com/haproxy/haproxy/blob/master/.github/workflows/musl.yml#L13-L14 |
justsmth
approved these changes
Aug 14, 2024
skmcgrail
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-621
CryptoAlg-2262
Description of changes:
This adds a new job to the General CI GitHub Actions workflow to build and test AWS-LC on Alpine Linux (x86_64 architecture), using both Clang and GCC compilers. This ensures AWS-LC remains compatible with musl-based systems, such as Alpine.
Call-outs:
Testing:
This new job runs the existing tests found in
tests/ci/run_posix_tests.sh
andtests/ci/run_fips_tests.sh
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.