-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PQ key exchange OIDs #1730
Merged
Merged
Add PQ key exchange OIDs #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
force-pushed
the
pq-kex-oids
branch
from
July 31, 2024 16:48
f2c8a67
to
bb3ed5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1730 +/- ##
=======================================
Coverage 78.30% 78.30%
=======================================
Files 580 580
Lines 96624 96623 -1
Branches 13853 13853
=======================================
+ Hits 75661 75662 +1
+ Misses 20347 20346 -1
+ Partials 616 615 -1 ☔ View full report in Codecov by Sentry. |
alexw91
approved these changes
Aug 1, 2024
WillChilds-Klein
force-pushed
the
pq-kex-oids
branch
2 times, most recently
from
August 5, 2024 15:54
37e9f01
to
5230bd8
Compare
The OID values are taken from OQS's [openssl provider][1]. [1]: https://github.com/open-quantum-safe/oqs-provider/blob/acd7181ae34ff05261d30d111eb5102d4f8c623a/ALGORITHMS.md?plain=1#L253-L254
WillChilds-Klein
force-pushed
the
pq-kex-oids
branch
from
August 5, 2024 16:06
5230bd8
to
0ac3576
Compare
dkostic
approved these changes
Aug 5, 2024
jakemas
approved these changes
Aug 5, 2024
andrewhop
approved these changes
Aug 5, 2024
justsmth
approved these changes
Aug 5, 2024
darylmartin100
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The OID values are taken from OQS's openssl provider.
The only manual changes in this PR were to
crypto/obj/objects.txt
. The rest were generated by runninggo run objects.go
in thecrypto/obj/
directory.Call-outs:
n/a
Testing:
pcap screenshot of above client Hello:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.