Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PQ key exchange OIDs #1730

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Jul 31, 2024

Description of changes:

The OID values are taken from OQS's openssl provider.

The only manual changes in this PR were to crypto/obj/objects.txt. The rest were generated by running go run objects.go in the crypto/obj/ directory.

Call-outs:

n/a

Testing:

# tested using this python fork https://github.com/WillChilds-Klein/cpython/tree/pq-tls

$ cat test.py
import ssl
import socket

assert "AWS-LC" in ssl.OPENSSL_VERSION

ctx = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
ctx.set_ecdh_curve("X25519Kyber768Draft00")
ctx.load_verify_locations("/etc/ssl/certs/ca-certificates.crt")

host = "secretsmanager.us-east-1.amazonaws.com"
sock = socket.create_connection((host, 443))
ssock = ctx.wrap_socket(sock, server_hostname=host)
ssock.close()
print("success!")

$ ./python test.py
success!
Screenshot 2024-07-31 at 8 08 58 PM

pcap screenshot of above client Hello:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@WillChilds-Klein WillChilds-Klein changed the title Pq kex oids Add PQ key exchange OIDs Jul 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (b929d74) to head (0ac3576).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1730   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files         580      580           
  Lines       96624    96623    -1     
  Branches    13853    13853           
=======================================
+ Hits        75661    75662    +1     
+ Misses      20347    20346    -1     
+ Partials      616      615    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review July 31, 2024 17:23
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner July 31, 2024 17:23
@WillChilds-Klein WillChilds-Klein merged commit f350674 into aws:main Aug 13, 2024
102 of 106 checks passed
@WillChilds-Klein WillChilds-Klein deleted the pq-kex-oids branch August 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants