Migrate to v4 of the codecov/codecov-action action #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
previously approved these changes
Apr 26, 2024
|
So it's not find the files that we're providing: https://github.com/aws/aws-lc/actions/runs/8841784960/job/24279427269?pr=1553#step:5:83 I wonder what changed? |
|
Not sure, we're still writing to that file: https://github.com/aws/aws-lc/actions/runs/8841784960/job/24279427269?pr=1553#step:4:1572 |
skmcgrail
previously approved these changes
Apr 29, 2024
samuel40791765
previously approved these changes
Apr 29, 2024
justsmth
changed the title
justsmth
dismissed stale reviews from samuel40791765, skmcgrail, and themself
via
f3d3ee8
justsmth
force-pushed
the
codecov
branch
2 times, most recently
from
f94e98c
to
8d43b5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 77.46% 77.91% +0.45%
==========================================
Files 435 560 +125
Lines 71873 94575 +22702
Branches 0 13611 +13611
==========================================
+ Hits 55676 73688 +18012
- Misses 16197 20293 +4096
- Partials 0 594 +594 ☔ View full report in Codecov by Sentry. |
justsmth
changed the title
|
"Codecov" throttling is at least part of the issue: codecov/feedback#358 |
samuel40791765
approved these changes
May 8, 2024
skmcgrail
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves P126361289
Description of changes:
V4 was released at the start of February and is the latest release.
Call-outs:
I'm just hoping this fixes the issue.
Testing:
In this CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.