Add an integration test for NTP #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
previously approved these changes
Dec 20, 2023
justsmth
reviewed
Jan 4, 2024
There was a problem hiding this comment.
The test is currently failing due to a missing symbol?
/usr/bin/ld: ../libntp/libntp.a(a_md5encrypt.o): in function `cmac_ctx_size':
/home/runner/work/aws-lc/aws-lc/NTP_BUILD_ROOT/ntp-4.2.8p17/libntp/a_md5encrypt.c:35: undefined reference to `CMAC_CTX_get0_cipher_ctx'
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:1110: ntpd] Error 1
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
- Coverage 76.84% 76.80% -0.05%
==========================================
Files 424 424
Lines 71410 71412 +2
==========================================
- Hits 54876 54846 -30
- Misses 16534 16566 +32 ☔ View full report in Codecov by Sentry. |
justsmth
previously approved these changes
Jan 5, 2024
justsmth
approved these changes
Jan 8, 2024
WillChilds-Klein
approved these changes
Jan 8, 2024
dougch
pushed a commit
to dougch/aws-lc
that referenced
this pull request
Jan 30, 2024
Add CMAC_CTX_get0_cipher_ctx for NTP, and add an integration test that builds NTP with AWS-LC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-2187
Description of changes:
With #1354 and #1355 AWS-LC is compatible with the latest version of NTP. This change adds a test to make sure we continue to work.
Call-outs:
AWS-LC already defines
OPENSSL_NO_MDC2in our public header files, however NTP currently doesn't check for that in their digest tests and expects to use MDC2. For now I added a patch to update the test and checkOPENSSL_NO_MDC2is not defined.NTP does not have an up to date GitHub mirror, it seems like the easiest way to get the code is from https://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/. Right now the integration script is hard coded to download 4.2.8p17 which is the latest right now.
Testing:
Built and ran locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.