Skip to content

Commit

Permalink
Fix MySQL version tag alarm (#1585)
Browse files Browse the repository at this point in the history
We got a false alarm when we updated the mysql version tag strategy.
Apparently my ubuntu box and the docker image had different versions of
git and this caused a behavioral difference when running `git tag
--sort=-taggerdate`.

The docker image has a newer version (`2.34.1`) and gives the tag date
in ascending order. This caused us to compare against the oldest version
of mysql instead and triggers the alarm. This PR fixes that.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
  • Loading branch information
samuel40791765 authored May 10, 2024
1 parent 8ae155b commit e82f824
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/ci/integration/run_mysql_integration.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ cd ${SCRATCH_FOLDER}

function mysql_patch_reminder() {
# Check latest MySQL version. MySQL often updates with large changes depending on OpenSSL all at once, so we pin to a specific version.
LATEST_MYSQL_VERSION_TAG=`git tag --sort=-taggerdate | head -n 1`
LATEST_MYSQL_VERSION_TAG=`git tag --sort=-taggerdate | tail -1`
if [[ "${LATEST_MYSQL_VERSION_TAG}" != "${MYSQL_VERSION_TAG}" ]]; then
aws cloudwatch put-metric-data --namespace AWS-LC --metric-name MySQLVersionMismatch --value 1
else
Expand Down

0 comments on commit e82f824

Please sign in to comment.