Update CRT #522
Merged
Update CRT #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
approved these changes
Aug 29, 2024
sfod
added a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in latest CRT to pull in MQTT-js major version upgrade
Updating the node types forced a revision of eventstream payload encoding because typescript does not appear to handle overloaded functions with union types as nicely as you would expect. For example,
Buffer.from()has overloads forArrayBufferandstring, but typescript will not let you pass a value of typestring | ArrayBufferintoBuffer.from()without error.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.