set linux sample & test macos by directly run the electron sample

aws · Jan 23, 2024 · bd47dd5 · bd47dd5
1 parent 419a631
commit bd47dd5
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -132,7 +132,10 @@ jobs:
         python3 ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_cfg.json
     - name: run PubSub Electron sample
       run: |
-        python ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_electron_cfg.json
+        cd aws-iot-device-sdk-js-v2/samples/node/pub_sub_electron_node
+        npm install .
+        npm start
+      # python ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_electron_cfg.json
     - name: run PKCS12 sample
       run: |
         cert=$(aws secretsmanager get-secret-value --region us-east-1 --secret-id "ci/PubSub/cert" --query "SecretString" | cut -f2 -d":" | cut -f2 -d\") && echo -e "$cert" > /tmp/certificate.pem
@@ -171,10 +174,10 @@ jobs:
     - name: run PubSub sample
       run: |
         python3 ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_cfg.json
-    # Skip Electron sample on linux. Launching Electron requires a display, while the linux CI does not has display linked.
-    # Error:
-    #   [8309:0122/203609.431374:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY
-    #   [8309:0122/203609.431431:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.
+    - name: run PubSub Electron sample
+      run: |
+        export DISPLAY=:0
+        python ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_electron_cfg.json
     - name: configure AWS credentials (Device Advisor)
       uses: aws-actions/configure-aws-credentials@v1
       with:
@@ -281,10 +284,10 @@ jobs:
     - name: run PubSub sample
       run: |
         python3 ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_cfg.json
-    # Skip Electron sample on linux. Launching Electron requires a display, while the linux CI does not has display linked.
-    # Error:
-    #   [8309:0122/203609.431374:ERROR:ozone_platform_x11.cc(247)] Missing X server or $DISPLAY
-    #   [8309:0122/203609.431431:ERROR:env.cc(226)] The platform failed to initialize.  Exiting.
+    - name: run PubSub Electron sample
+      run: |
+        export DISPLAY=:0
+        python ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_electron_cfg.json
     - name: run PubSub JS sample
       run: |
         python3 ./aws-iot-device-sdk-js-v2/utils/run_in_ci.py --file ./aws-iot-device-sdk-js-v2/.github/workflows/ci_run_pubsub_js_cfg.json