Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme cleanup #644

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Readme cleanup #644

merged 3 commits into from
Oct 17, 2023

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Oct 9, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -32,10 +32,8 @@ cd sdk-workspace
git clone --recursive https://github.com/aws/aws-iot-device-sdk-cpp-v2.git
# Ensure all submodules are properly updated
cd aws-iot-device-sdk-cpp-v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change into this directory and change back out of this directory.

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd into dir and cd .. ship

Copy link
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Codebuild was failed because of ubuntu-toolchain. Rerun the CI should fix it.

@jmklix jmklix merged commit a3392e6 into main Oct 17, 2023
36 checks passed
@jmklix jmklix deleted the readme-cleanup branch October 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants