fix: upload-artifact breaking change #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Will also try bumping upload artifact. |
|
Seems maybe related to actions/upload-artifact#602. Going to try adding |
keenangraham
changed the title
keenangraham
changed the title
keenangraham
changed the title
|
K, looks like both build and package steps are passing now. |
|
Some fork weirdness where latest build tried to checkout duplicate branch that I had deleted. Trying to bump commit hash so git checkout doesn't get confused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Looks like underlying problem is that
upload-artifactpushed silent breaking change: actions/upload-artifact#602This restores
actions/download-artifactin Github workflow to newer version used in #185, but pins it in.projenrc.jsso it doesn't revert to old versions when you runnpx projen.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license