Skip to content

Commit

Permalink
Working
Browse files Browse the repository at this point in the history
  • Loading branch information
keenangraham committed Dec 4, 2024
1 parent 11896bc commit 579d2a7
Show file tree
Hide file tree
Showing 5 changed files with 270 additions and 572 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class Karpenter extends Construct {
name: this.serviceAccountName,
namespace: this.namespace,
});


// Setup the controller IAM Policy statements
this.addControllerPolicyIAMPolicyStatements();
Expand Down Expand Up @@ -191,7 +191,7 @@ export class Karpenter extends Construct {
// will override the dynamic values.
values: { ...this.helmExtraValues, ...this.helmChartValues },
});


// If we are not installing it in the `kube-system` namespace:
// Note: We should be installing it in kube-system, please see: https://github.com/aws/karpenter-provider-aws/blob/fd2b60759f81dc0c868810cc44443103067c4880/website/content/en/v0.36/upgrading/upgrade-guide.md?plain=1#L91
Expand All @@ -204,7 +204,7 @@ export class Karpenter extends Construct {
name: this.namespace,
},
});
// If we are creating a namespace, we need to link it to the service account and the chart, so they are deployed in the correct order.
// If we are creating a namespace, we need to link it to the service account and the chart, so they are deployed in the correct order.
this.serviceAccount.node.addDependency(namespace);
this.chart.node.addDependency(namespace);
}
Expand Down
Loading

0 comments on commit 579d2a7

Please sign in to comment.