fix for cross region s3 template processing #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjjaegeraws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This fixes the S3 API cross-region call when trying to provision 3rd party firewalls that use a configuration file. If the 3rd party firewalls are being deployed in ca-west-1, but the configuration files are in ca-central-1 (home region) this error will be encountered:
Error: Unable to get S3 object s3://asea-management-phase0-configcacentral1-1g9ucir5s5ry0/firewall/firewall-example-A-A-multitunnel.txt: IllegalLocationConstraintException: The ca-central-1 location constraint is incompatible for the region specific endpoint this request was sent to.The fix below uses the config bucket's home region as a parameter to the locationconstraint in the S3 API.