Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subnetcidr pools #1220

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

rjjaegeraws
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This fixes the Security Group rules when referencing a different subnets. The code's lookup functionality was always returning empty because it had no data populated to query.

To verify:

In a workload account, inspect the Mgmt security group. With the default config, it is expected to see ingress rules with descriptions of 'Central VPC Traffic Inbound from...'
Apply fix and run state machine, expected Security Group Ingress rules exist.

Copy link
Contributor

@hickeydh-aws hickeydh-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rjjaegeraws rjjaegeraws marked this pull request as ready for review March 8, 2024 17:36
@archikierstead archikierstead merged commit b31529a into aws-samples:main Mar 8, 2024
6 checks passed
@rjjaegeraws rjjaegeraws deleted the security_group_fix branch March 8, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants