feat: enable polyglot otel config #287
Conversation
There was a problem hiding this comment.
LGTM. This works great and tested. @bonclay7 Can you review and merge it. Need for RI Setup.
There was a problem hiding this comment.
Looks good but tests are failing. Can you run pre-commit and commit changes @hmuthusamy
https://github.com/aws-observability/terraform-aws-observability-accelerator/actions/runs/11522847911/job/32088304356?pr=287
@bonclay7 Ran the pre-commit and submitted for review. Please review and merge. Thanks |
|
@hmuthusamy Precommit is failing still. Lets fix it. |
|
Getting the below error on pr-commit. It runs fine when i ran the same PR locally. Terraform docs...........................................................Failed
There are some problems with the CLI configuration: As a result of the above problems, Terraform may not behave as intended. |
bonclay7
changed the title
| kubernetes_sd_configs: | ||
| - role: pod |
There was a problem hiding this comment.
This seems a bit wide, as without any relabel config or port capture, it would capture any exposed metrics at the pod level unless i'm missing something. Can you make it more specific to what you are collecting?
There was a problem hiding this comment.
@bonclay7 Happy to discuss this on a call. We are going to setup .net, Rust,Go and other dashboards as part of the RI workshop. We opened up all the pods (defaulted to false and only explicitly set to true) for the usecase. Once we finalize all the metrics for all these languages/apps and understand what filters we need to apply we will apply them along with corresponding dashboards similar to how its implemented for Java.
|
Fixed the tests, but I have one concern @hmuthusamy |
|
@bonclay7 Pls merge this or let us know if you have questions. This is blocker for RI. We are having enable for polyglot flag so pod level metrics isnt going to be a problem. This flag willbe disabled by default |
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.
Fix for nginx and java monitoring dashboards on EKS failing because of race condition deploying dashboards first before flux is deployed.
Also added polyglot monitoring for Rust,.Net monitoring using OTEL.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes