-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Key rotation for Grafana Workspace #259
Conversation
…e changes to the eks-monitoring module and examples/existing-cluster-with-base-and-infra directory
Tagging reviewers --> @bonclay7 @lewinkedrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I did leave some comments with a few small fixes. We also need a doc for this. Can you write a markdown file in the docs folder describing how to use this module? Do not worry about the folder structure or where in the website to place the doc, we can do that part. But in the doc give a brief intro to what this module does, how to enable it or disable it, and describe some of the configuration options available to the users. Thank you for the contribution though it is looking very nice!
…an be found in the comments of the Pull Request.
Made the following changes to incorporate the suggestions from @lewinkedrs :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please address this change, re-run pre-commit, and test it once more, as I've fixed some conflicts in your branch.
Thanks again for the work!
… be found in the comments of the Pull Request.
… be found in the comments of the Pull Request.
… be found in the comments of the Pull Request.
Made the changes suggested by @bonclay7 and removed |
This PR has been automatically marked as stale because it has been open 60 days |
Working on the incorporating unit tests for the Lambda function per my conversation with bonclay7@ |
…ormation can be found in the comments of the Pull Request.
…ormation can be found in the comments of the Pull Request.
Added Unit Tests for Lambda function in the |
This PR has been automatically marked as stale because it has been open 60 days |
Closing this PR as Managed Grafana v9 and 10 introduced Service account and service account token (SAT) APIs, instead of API Keys. |
What does this PR do?
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes