Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eks 1.28 migrate kubectl provider to alekc repo #245

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

rlanore
Copy link
Contributor

@rlanore rlanore commented Dec 8, 2023

What does this PR do?

Fix issue with gavinbunney/kubectl on eks 1.28. Some resource disappear or re-created on every tf apply

Migrate to alekc/kubectl providers

close #244

Motivation

Make it work on every tf apply with eks 1.28

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7
Copy link
Member

Hey thanks for this PR!

@bonclay7 bonclay7 self-requested a review December 14, 2023 13:15
Migrate kubectl provider to alekc repo
@rlanore
Copy link
Contributor Author

rlanore commented Dec 14, 2023

Hi, weird i had miss a commit. sorry
LGTM now without tfsec

[] 🠶 pre-commit run -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
detect private key.......................................................Passed
detect aws credentials...................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate.......................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate with tfsec............................................Failed

Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@bonclay7 bonclay7 merged commit dee3dcb into aws-observability:main Dec 14, 2023
26 checks passed
@bonclay7 bonclay7 mentioned this pull request Dec 18, 2023
5 tasks
@rlanore rlanore deleted the alekc-kubectl branch December 19, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some kubectl_manifest resource to be re-created sporadically in EKS 1.28
2 participants