Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra labels from env #25

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

bitkill
Copy link
Contributor

@bitkill bitkill commented Mar 22, 2023

Issue #, if available:
none

Description of changes:

  • New feature: Add custom labels to the prometheus metrics via the EXTRA_LABELS environment variable

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bitkill bitkill marked this pull request as ready for review July 6, 2023 17:38
@lewinkedrs
Copy link
Collaborator

Hey @bitkill , Sorry, this one fell through the cracks. Can you pull in the latest changes from upstream into your branch. Then we can review and merge. Thank you for your contribution!

@lewinkedrs lewinkedrs self-requested a review October 4, 2023 13:14
Copy link
Collaborator

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contributing.

@lewinkedrs lewinkedrs merged commit 61353ac into aws-observability:main Oct 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants